add equality and hashability to Retry and backoff classes
#3628
+111
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds equality and hashability methods to the Retry and various backoff classes to support reliable comparisons between retry instances in downstream libraries.
- Introduces eq and hash for Retry and multiple backoff classes.
- Augments the test suite with new test cases to validate equality/hashability behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_retry.py | Adds tests validating equality and hashability of Retry instances. |
| redis/retry.py | Implements eq and hash methods for the Retry class. |
| redis/backoff.py | Adds equality and hashability implementations for several backoff types. |
terencehonles
force-pushed
the
add-equality-and-hashability-to-retry-classes
branch
4 times, most recently
from
464721d to
5b9fe2e
Compare
petyaslavova
reviewed
May 5, 2025
redis/backoff.py
Outdated
| return ( | ||
| self._base == other._base | ||
| and self._cap == other._cap | ||
| and self._previous_backoff == other._previous_backoff |
There was a problem hiding this comment.
I think that you should not compare the _previous_backoff fields- they represent the progress/state of the objects, not the configuration. For example, it is also not included in the hash of the object.
There was a problem hiding this comment.
Sure, I wasn't sure if the current state should affect it, but guess that's not usually what someone might care about
terencehonles
force-pushed
the
add-equality-and-hashability-to-retry-classes
branch
from
31e489d to
bd59a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change adds equality and hashability to
Retryand backoff classes.This broke in DjangoRQ (fixed) after #3622 / #3614 and I provided a workaround in rq/django-rq#706, but this allows other downstream libraries to compare two retry instances.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.